Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CIDR required in 'civo_firewall_rule' #75

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

zulh-civo
Copy link
Member

Close #70

@zulh-civo
Copy link
Member Author

@alejandrojnm - I have to remove the validation because ValidateFunc only works for primitive types.

It's causing error in our CI:

Screenshot 2021-09-02 at 9 50 19 AM

So you review this again?

@zulh-civo zulh-civo merged commit 0bbeab8 into master Sep 2, 2021
@alejandrojnm alejandrojnm deleted the require-cidr-in-firewall-rule branch November 10, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firewall rule CIDR should be required
2 participants