Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpotifyiOS/SpotifyiOS.h #25

Closed
adrianosbr opened this issue Jan 18, 2020 · 7 comments
Closed

SpotifyiOS/SpotifyiOS.h #25

adrianosbr opened this issue Jan 18, 2020 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@adrianosbr
Copy link

adrianosbr commented Jan 18, 2020

Thank you so much for this library and for the wonderful update :)

I created a new project just to test the library's new version and detected a problem. The headers for the Spotify SDK are now into a weird "Versions/A/Headers" folder and that prevents Xcode to build the app.

I just copied them directly to a "Headers" folder and now it works flawlessly ;)

@lucasgismondi
Copy link

lucasgismondi commented Jan 18, 2020

+1 the great update! Also experiencing this issue. However, I see that the "Versions/A/Headers" directory is also in v0.0.8

@cjam
Copy link
Owner

cjam commented Jan 18, 2020

Ah yes. Are you using CocoaPods or just linking manually. The CocoaPods handles all of this for you. But I suppose a few docs about this in the manual linking section of the docs might be helpful.

@cjam cjam added the documentation Something that needs to be documented. label Jan 18, 2020
@adrianosbr
Copy link
Author

I used Cocoapods.

@cjam
Copy link
Owner

cjam commented Jan 18, 2020

Hmm interesting, because this:

s.source_files = "ios/*.{h,m}","ios/external/SpotifySDK/SpotifyiOS.framework/**/Headers/*.{h,m}"

Should take care of that part. Did you do a pod install after updating?

@lucasgismondi
Copy link

I use cocoapods also and yes I did run pod install after the upgrade.

@cjam
Copy link
Owner

cjam commented Jan 18, 2020

Hmm, I'll investigate when I integrate it into my own project.

@cjam cjam added bug Something isn't working and removed documentation Something that needs to be documented. labels Jan 20, 2020
cjam added a commit that referenced this issue Jan 21, 2020
- Prepublish step that unwraps symlinked headers and framework
@cjam cjam self-assigned this Jan 21, 2020
cjam added a commit that referenced this issue Jan 21, 2020
* Fix for #25
- Prepublish step that unwraps symlinked headers and framework

* Updating Changelog
@cjam
Copy link
Owner

cjam commented Jan 21, 2020

Thanks for the report on this one.

For those curious. NPM publish follows but strips out symlinks from packages.
Apparently I had manually moved some files around in the SpotifySDK submodule (i.e. Headers, SpotifyiOS framework) that were published in 0.8.0 so everything worked fine, but when I updated to SDK 1.2 it reverted back to the symlinked structure. Took me a while to figure out if it was an issue that could be solved with the podspec or something else.

I've added some prepack postpack scripts to the package.json that make sure the Headers and Framework files are at the root right before publishing.

Things should work without any modification to your project / pods project in v0.1.1

@cjam cjam closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants