Fix iOS returning access token instead of session object when re-authing #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djwillcaine
force-pushed
the
master
branch
2 times, most recently
from
305d9df
to
c3a25ef
Compare
|
Re-opening under a new PR with the commits organised a bit better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a call to the
authorizemethod I noticed a bug in the iOS implementation. The first time it is called, a session object is correctly returned. If the method is called a second time, when a session has already been initialized, it incorrectly returns just the accessToken string as opposed to the whole session object.Tested and working :)