Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support kotlinx.serialization #89

Open
christophsturm opened this issue Dec 2, 2021 · 6 comments
Open

support kotlinx.serialization #89

christophsturm opened this issue Dec 2, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@christophsturm
Copy link

This library looks great, are you planning to add support for kotlinx serialization, or would you accept a pr that adds it?

@cjbooms
Copy link
Owner

cjbooms commented Dec 2, 2021

I would be very receptive to PRs, but have no experience with kotlinx serialization.

@ulrikandersen
Copy link
Collaborator

@zettelmj Have you been able to make progress on adding Kotlinx Serialization to the library?

@Serisium
Copy link

Serisium commented Jul 5, 2024

@zettelmj and @ulrikandersen, I am interested in tackling this feature. How has your experience been so far, and do you have any advice for getting started?

Thank you for your work so far!

@ulrikandersen
Copy link
Collaborator

ulrikandersen commented Jul 7, 2024

@Serisium I am happy to help with code reviews and feedback along the way! It would be a great addition to the library 🙌

@zettelmj has taken the first steps in #249, so I guess that would be the place to start.

@zettelmj
Copy link
Collaborator

Hi Sorry for the late answer. I did try to tackle the whole problem at once. In retrospective that is most probably a step too big. I should have gone for the model part first. I would suggest the same: Add the code that allows for the model part of the process in first. I am planning to look into adding end 2 end tests for the existing Jackson based serialisation over the weekend.

@ulrikandersen
Copy link
Collaborator

With the release of 18.0.0, Fabrikt is now capable of generating models with kotlinx.serialization annotations.

Take it for a spin, and please do not hesitate to share feedback and/or open PRs with suggestions for improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants