Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General dependency update #181

Merged

Conversation

chris-hatton
Copy link
Contributor

@chris-hatton chris-hatton commented Apr 1, 2023

I am interested in taking on issue #89, to support kotlinx.serialization.

In preparation, I checked out master and observed that dependencies were generally somewhat out-of-date. I've updated them here before adding support for the latest kotlinx.serialization version.

A couple of minor changes arose to account for the new dependencies:

  1. Dokka now prefers to expose a task-per-output-format, than have a single output format selected. I imagine this is to support output of multiple formats. The way the task is acquired for the kotlinDocJar task then had to change.
  2. Kotlin Poet now supports multple 'simpleName's; I'm not sure why to be honest but fixing our usage was a simple case of removing the single argument label.

Unit tests passing locally ✅

@cjbooms
Copy link
Owner

cjbooms commented Apr 11, 2023

👍

@cjbooms
Copy link
Owner

cjbooms commented Apr 11, 2023

Thanks @chris-hatton

@cjbooms cjbooms changed the base branch from master to dependency-update April 11, 2023 20:32
@cjbooms cjbooms changed the base branch from dependency-update to master April 11, 2023 20:35
@cjbooms cjbooms changed the base branch from master to dependency-update April 11, 2023 20:35
@cjbooms cjbooms merged commit f3cba4f into cjbooms:dependency-update Apr 11, 2023
zettelmj pushed a commit that referenced this pull request Sep 18, 2023
cjbooms added a commit that referenced this pull request Sep 19, 2023
* General dependency update (#181)

* Fix expected code to match generated code

* Bumping KotlinPoet to latest and undoing some questionable changes to the code generated by previous version

---------

Co-authored-by: Chris Hatton <christopherhattonuk@gmail.com>
Co-authored-by: Jens Zettelmeyer <zettelmj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants