Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL class requires name resolution to work when equals() function is … #248

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

zettelmj
Copy link
Collaborator

@zettelmj zettelmj commented Oct 26, 2023

URL class requires name resolution to work when equals() function is called.

The equals() function on the URL class requires name resolution to work. In offline scenarios the call can therefor fail.

From the docs:

     * Two hosts are considered equivalent if both host names can be resolved
     * into the same IP addresses; else if either host name can't be
     * resolved, the host names must be equal without regard to case; or both
     * host names equal to null.<p>
     *
     * Since hosts comparison requires name resolution, this operation is a
     * blocking operation. <p>

@cjbooms cjbooms merged commit 46b2985 into master Nov 7, 2023
1 check passed
@ulrikandersen ulrikandersen deleted the do_not_use_url_class branch October 18, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants