Do not strip discriminator property in oneOf generation. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbooms
commented
Mar 1, 2024
| @@ -462,22 +465,8 @@ class JacksonModelGenerator( | |||
| extensions: Map<String, Any>, | |||
| oneOfInterfaces: Set<SchemaInfo>, | |||
| ): TypeSpec { | |||
| val filteredProperties = if (oneOfInterfaces.size == 1) { | |||
There was a problem hiding this comment.
This is the logic in question. I'm not sure of the intent here, but perhaps @pschichtel can weigh in before I revert it
There was a problem hiding this comment.
the logic is:
if:
- the super interface' model defines a discriminator field
- the discriminator mappings map to the current model exactly once
then:
- remove the discriminator field, since it must always be the same value given by the jackson type info field.
|
I personally think this is a mistake. |
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title and Issue #258 it does not seem correct to be stripping a declared property from the data classes.
Instead, adopt the same approach as allOf polymorphism and default the discriminator to the correct value