Skip to content

Commit

Permalink
unix: remove FSEventStreamFlushSync() call
Browse files Browse the repository at this point in the history
This call, in the context of file watching, appears to trigger
assertion warnings on some macOS configurations.

Refs: nodejs/node#854
Fixes: libuv#1334
PR-URL: libuv#1349
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
  • Loading branch information
cjihrig committed May 16, 2017
1 parent e11dcd4 commit 1217832
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/unix/fsevents.c
Original file line number Diff line number Diff line change
Expand Up @@ -378,9 +378,6 @@ static void uv__fsevents_destroy_stream(uv_loop_t* loop) {
if (state->fsevent_stream == NULL)
return;

/* Flush all accumulated events */
pFSEventStreamFlushSync(state->fsevent_stream);

/* Stop emitting events */
pFSEventStreamStop(state->fsevent_stream);

Expand Down

0 comments on commit 1217832

Please sign in to comment.