Skip to content

Commit

Permalink
src: remove unnecessary req_wrap_obj
Browse files Browse the repository at this point in the history
The req_wrap_obj is only used in one place which is setting up the
arguments for the MakeCallback call. Removing it to simplify the code
somewhat.

PR-URL: nodejs#10942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
  • Loading branch information
danbev authored and jasnell committed Jan 23, 2017
1 parent c8c79b9 commit 00679c3
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/connection_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,10 @@ void ConnectionWrap<WrapType, UVType>::AfterConnect(uv_connect_t* req,
writable = uv_is_writable(req->handle) != 0;
}

Local<Object> req_wrap_obj = req_wrap->object();
Local<Value> argv[5] = {
Integer::New(env->isolate(), status),
wrap->object(),
req_wrap_obj,
req_wrap->object(),
Boolean::New(env->isolate(), readable),
Boolean::New(env->isolate(), writable)
};
Expand Down

0 comments on commit 00679c3

Please sign in to comment.