Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use with morphMaps #39

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

cjmellor
Copy link
Owner

@cjmellor cjmellor commented Oct 2, 2023

This PR fixes a bug where when morphMap is used, it would error when approving the Model because it didn't recognise the new string format of the approvalable_type.

Closes #38

@cjmellor cjmellor added the bug Something isn't working label Oct 2, 2023
@cjmellor cjmellor self-assigned this Oct 2, 2023
@cjmellor cjmellor linked an issue Oct 2, 2023 that may be closed by this pull request
@cjmellor cjmellor merged commit 0994661 into main Oct 2, 2023
5 checks passed
@cjmellor cjmellor deleted the 38-approval-fails-for-models-with-a-morphmap branch October 2, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Approval fails for models with a morphMap
1 participant