Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix array attributes #47

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Conversation

gerb-ster
Copy link
Contributor

Possible fix for issue #45

@cjmellor cjmellor added the bug Something isn't working label Nov 9, 2023
@cjmellor
Copy link
Owner

cjmellor commented Nov 9, 2023

@gerb-ster I've just inlined the test, and just changed few bits to match my style.

Interesting way of fixing this, I wouldn't have even thought of this way, haha.

If you're happy with my change, approve it and I can merge.

@nunodonato
Copy link
Contributor

@gerb-ster please approve this :D

@cjmellor cjmellor merged commit c772e36 into cjmellor:main Nov 13, 2023
5 checks passed
@cjmellor
Copy link
Owner

Didn't want to wait much longer so just gonna merge it

@gerb-ster
Copy link
Contributor Author

@cjmellor Sorry, got a bit side-tracked :) thx for merging it!

@nunodonato
Copy link
Contributor

yay, thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants