Add model and user to all event constructors #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to let all events receive the model and the authenticated user that triggered it.
On second thought, I think it might be more beneficial to change the constructor parameters to receive the
Approval
model itself, instead of the eloquent model that was changed. This is because from theApproval
we can easily get to the subject, while the opposite might not be true (when a model has multipleApprovals
).What do you think @cjmellor ?