Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Get back to a working state #1224

Merged
merged 6 commits into from
Jun 25, 2024
Merged

ci: Get back to a working state #1224

merged 6 commits into from
Jun 25, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Jun 24, 2024 •
edited
Loading

  • fd25b26 ci: Qualify constraints file with workspace directory
  • 84c908e Bump vulnerable deps in poetry.lock
  • d42a4d2 Apply black formatting
  • 39b5291 Ignore safety false positives
  • 1e45b9e XFail invalid packaging requirement
  • 0fce654 Ignore untested exception

@edgarrmondragon edgarrmondragon changed the title ci: Qualify constraints file with workspace directory ci: Get back to a working state Jun 24, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review June 24, 2024 20:06
edgarrmondragon
edgarrmondragon commented Jun 24, 2024
View reviewed changes
tests/unit/test_sessions.py
@@ -179,6 +180,7 @@ def test_to_constraints(requirements: str, expected: str) -> None:
assert to_constraints(requirements) == expected


@pytest.mark.xfail(reason="This requirement now seems to be valid.")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjolowicz let me know how you'd prefer to deal with this

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me for now

@cjolowicz cjolowicz merged commit fb20b69 into cjolowicz:main Jun 25, 2024
18 checks passed
@cjolowicz
Copy link
Owner

Thank you!

@edgarrmondragon edgarrmondragon deleted the ci/workspace-path branch June 25, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjolowicz cjolowicz cjolowicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarrmondragon @cjolowicz