refactor!: move favicon site param to page param #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves and renames `.Site.params.faviconEmojiTemplate` to `.Page.params.faviconText`. This both clarifies that the parameter accepts any text - not necessarily an emoji, as well as furthering a wider effort to make this page fully configurable from one location. * refactor: move favicon template to head partial We move the favicon svg template to the head partial, since it will never be used anywhere else. * fix: bust favicon cache during development While using `hugo server`, the first generated favicon would cached and used for the duration. We now name the generated resource with its md5 hash to prevent this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves and renames
.Site.params.faviconEmojiTemplateto.Page.params.faviconText. This both clarifies that the parameter accepts any text - not necessarily an emoji, as well as furthering a wider effort to make this page fully configurable from one location.We move the favicon svg template to the head partial, since it will never be used anywhere else.
While using
hugo server, the first generated favicon would cached and used for the duration. We now name the generated resource with its md5 hash to prevent this.