Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sharing of Redis database #257

Closed
torfsen opened this issue Jul 20, 2016 · 0 comments
Closed

Allow sharing of Redis database #257

torfsen opened this issue Jul 20, 2016 · 0 comments

Comments

@torfsen
Copy link
Contributor

torfsen commented Jul 20, 2016

CKAN core is currently moving towards Redis as a hard dependency, for example for its new background job queue (ckan/ckan#3165). This means that CKAN and ckanext-harvest should be able to share a Redis database.

ckanext-harvest already prefixes its Redis keys appropriately, but Redis queue purging currently empties the whole database. This must be fixed so that only the ckanext-harvest keys of the current CKAN instance are removed. That can be done using Redis' support for LUA scripts, see for example the queue cleaning in RQ.
torfsen added a commit to torfsen/ckanext-harvest that referenced this issue Jul 20, 2016
@torfsen
[ckan#257] Purge only our own Redis data.
f8aedb1 
Previously purging the queue on the Redis backend would clear the whole
database, making it hard to share the same database with other parts of
CKAN. With this commit, only the keys that belong to ckanext-harvest and
the current CKAN instance are purged.
This was referenced Jul 20, 2016
Merged
Merged
torfsen added a commit to torfsen/ckanext-harvest that referenced this issue Jul 20, 2016
@torfsen
[ckan#257] Purge only our own Redis data.
2602de9 
Previously purging the queue on the Redis backend would clear the whole
database, making it hard to share the same database with other parts of
CKAN. With this commit, only the keys that belong to ckanext-harvest and
the current CKAN instance are purged.
davidread pushed a commit that referenced this issue Jul 20, 2016
Merge pull request #258 from torfsen/257-allow-sharing-of-redis-database
2208da6 
[#257] Purge only our own Redis data.
@earthlyreason earthlyreason mentioned this issue Jul 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@torfsen