Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip protected fields #472

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Skip protected fields #472

merged 2 commits into from
Mar 4, 2022

Conversation

frafra
Copy link
Contributor

@frafra frafra commented Oct 22, 2021

Fix #464.

Copy link
Member

@amercader amercader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @frafra , see comments. Also can you document this in the README please? Thanks

ckanext/harvest/harvesters/base.py Outdated Show resolved Hide resolved
ckanext/harvest/harvesters/base.py Outdated Show resolved Hide resolved
@frafra
Copy link
Contributor Author

frafra commented Mar 4, 2022

@amercader Thanks for the review. Fixes and improvements applied.

@amercader amercader merged commit ed6c4e1 into ckan:master Mar 4, 2022
@frafra frafra deleted the protect-fields branch March 4, 2022 10:43
LittleRed945 pushed a commit to LittleRed945/ckanext-harvest that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protect specific metadata
2 participants