Add option keep-current to clearsource_history command #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this option should be called "keep-current" instead of "keep-actual", since you want to keep the current active object. WDYT? |
|
@metaodi Yes, I think same. Our intention was changing as less as possible from the pull request this one is based on. But you have convinced me to make the changes. If nobody else wants to keep the current naming of the variable we will rename it to |
seitenbau-govdata
changed the title
seitenbau-govdata
deleted the
fix-clearsourcehistory-command-keep-latest-objects
branch
This was referenced May 12, 2022
LittleRed945
pushed a commit
to LittleRed945/ckanext-harvest
that referenced
this pull request
Sep 22, 2022
…ry-command-keep-latest-objects Add option keep-current to clearsource_history command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #397 we added the option to keep the latest related objects to a harvest source when running clearsource_history.