chore: cicd, CKAN 2.9.x #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing because of compatibility problems with |
duttonw
force-pushed
the
chore_cicd_toml_2.9_only
branch
from
810bb4b to
63dbc41
Compare
ThrawnCA
requested changes
Dec 10, 2024
| name: CKAN ${{ matrix.ckan-version }} | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: openknowledge/ckan-dev:${{ matrix.ckan-version }} |
There was a problem hiding this comment.
Shouldn't this use ckan/ckan-dev?
There was a problem hiding this comment.
i'm getting a 2.9 cut to pypi then we will be moving to ckan/ckan-dev which has test failure.
| pip install -r dev-requirements.txt | ||
| echo "no-warn-conflicts install of jinja2 and markupsafe" | ||
| pip install --no-warn-conflicts jinja2==2.10.1 | ||
| pip install --no-warn-conflicts markupsafe==2.0.1 |
There was a problem hiding this comment.
This could be combined with the previous line.
There was a problem hiding this comment.
this is how it was previously, just leaving it alone until we do the 2.10+ uplift.
ThrawnCA
reviewed
Dec 10, 2024
|
|
||
| test: | ||
| needs: lint | ||
| strategy: | ||
| matrix: | ||
| ckan-version: [2.9] | ||
| include: #ckan-image see https://github.com/ckan/ckan-docker-base, ckan-version controls other image tags | ||
| # - ckan-version: "2.11" |
There was a problem hiding this comment.
Why not uncomment these since they are marked experimental?
ThrawnCA
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get a release out that supports CKAN 2.9.x prior to dropping support.
#103 will look after the uplift (as well as incorporating parts of qld-gov-au downstream fork where needed)