Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v2 branch with support to Py3 and CKAN >= 2.9 only #66

Merged
merged 96 commits into from
Dec 1, 2022
Merged

Conversation

aivuk
Copy link
Contributor

@aivuk aivuk commented Jul 28, 2022

Fixes #63

@aivuk aivuk requested a review from amercader July 28, 2022 11:00
@aivuk aivuk self-assigned this Jul 28, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #66 (bd79867) into master (f151aa5) will increase coverage by 1.63%.
The diff coverage is 94.71%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   82.70%   84.33%   +1.63%     
==========================================
  Files          26       24       -2     
  Lines        2157     2088      -69     
==========================================
- Hits         1784     1761      -23     
+ Misses        373      327      -46     
Impacted Files Coverage Δ
ckanext/validation/jobs.py 82.85% <83.92%> (-0.07%) ⬇️
ckanext/validation/helpers.py 88.88% <87.50%> (+9.40%) ⬆️
ckanext/validation/plugin/__init__.py 95.80% <90.90%> (-1.38%) ⬇️
ckanext/validation/logic.py 68.27% <94.59%> (-0.39%) ⬇️
ckanext/validation/model.py 100.00% <100.00%> (ø)
ckanext/validation/tests/fixtures.py 100.00% <100.00%> (ø)
ckanext/validation/tests/helpers.py 100.00% <100.00%> (+1.88%) ⬆️
ckanext/validation/tests/test_form.py 100.00% <100.00%> (+19.83%) ⬆️
ckanext/validation/tests/test_interfaces.py 98.11% <100.00%> (-0.06%) ⬇️
ckanext/validation/tests/test_jobs.py 100.00% <100.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ThrawnCA
Copy link
Contributor

What's the benefit of ditching all the cross-version compatibility?

amercader and others added 26 commits October 21, 2022 13:12
…onlessdata/ckanext-validation into use-frictionless-report-component
Co-authored-by: Adrià Mercader <amercadero@gmail.com>
Co-authored-by: Adrià Mercader <amercadero@gmail.com>
…ssdata/ckanext-validation into use-frictionless-framework-v5
Co-authored-by: Adrià Mercader <amercadero@gmail.com>
…ssdata/ckanext-validation into use-frictionless-framework-v5
…onlessdata/ckanext-validation into use-frictionless-report-component
…component

Uses new frictionless report component to display validation report
@aivuk aivuk marked this pull request as ready for review December 1, 2022 13:25
@aivuk aivuk merged commit 9c23581 into master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create v2 development branch
3 participants