Use IDomainObjectModification Implementation #198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(dev): use
IDomainObjectModification
implementation;IDomainObjectModification
instead ofIResourceUrlChange
for automagic exception handling.Currently, the
notify
method from theIResourceUrlChange
implementation is assuming that the Resource exists in theresource_show
action call. But, at this point, other extensions (namely Validation running in sync mode) can delete the Resource from the session before it is committed. This would do a error here.So using
IDomainObjectModification
instead, will automagically handle exceptions, logging them, and just passing so that normal operations will resume.