Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IDomainObjectModification Implementation #198

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

JVickery-TBS
Copy link
Contributor

fix(dev): use IDomainObjectModification implementation;

  • Use IDomainObjectModification instead of IResourceUrlChange for automagic exception handling.

Currently, the notify method from the IResourceUrlChange implementation is assuming that the Resource exists in the resource_show action call. But, at this point, other extensions (namely Validation running in sync mode) can delete the Resource from the session before it is committed. This would do a error here.

So using IDomainObjectModification instead, will automagically handle exceptions, logging them, and just passing so that normal operations will resume.

- Use `IDomainObjectModification` instead of `IResourceUrlChange` for automagic exception handling.
@ThrawnCA ThrawnCA merged commit 55a344d into ckan:master Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants