Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable 'paste' and 'afterPaste' tests on FF #119

Open
Dumluregn opened this issue Jul 16, 2020 · 9 comments
Open

Unstable 'paste' and 'afterPaste' tests on FF #119

Dumluregn opened this issue Jul 16, 2020 · 9 comments
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. status:confirmed An issue confirmed by the development team. type:failingtest A failing test.

Comments

@Dumluregn
Copy link
Collaborator

Dumluregn commented Jul 16, 2020

Are you reporting a feature request or a bug?

Unstable tests

Provide detailed reproduction steps (if any)

  1. Run tests with npm run test
  2. See the result in FF
  3. If everything passed, try again

Expected result

Tests pass each time.

Actual result

Tests for paste and afterPaste events are unstable and fail sometimes.

Other details

I'm not sure but it can be caused by changes introduced in #115.

  • Browser: FF 78
  • OS: macOS
  • Integration version: 1.2.2
  • CKEditor version: 4.14.1
  • Installed CKEditor plugins: default
@Dumluregn Dumluregn added status:confirmed An issue confirmed by the development team. workload:medium type:failingtest A failing test. labels Jul 16, 2020
@f1ames
Copy link
Contributor

f1ames commented Jul 16, 2020

That's sad as we just fixed it for IE11 😭 Anyway, maybe fixes introduced in #115 should be done for IE11 only and for the rest of the browsers it should be done as before the fix 🤔

@Dumluregn Dumluregn added this to the 1.3.0 milestone Jul 22, 2020
@Dumluregn Dumluregn added the browser:firefox The issue can only be reproduced in the Firefox browser. label Jul 22, 2020
@jacekbogdanski jacekbogdanski self-assigned this Jul 28, 2020
@jacekbogdanski
Copy link
Member

I cannot reproduce it on Linux Fedora 32. They also don't seem to fail on CI. @Dumluregn is this issue macOS specific?

@jacekbogdanski jacekbogdanski removed their assignment Jul 28, 2020
@Dumluregn
Copy link
Collaborator Author

Not sure. It occurs pretty consistently for me, so if you can't reproduce it you may be right that it happens on macOS only. @f1ames @hub33k could you check if tests fail on your machines?

@hub33k
Copy link
Contributor

hub33k commented Jul 30, 2020

It fails on my machine (Manjaro Linux). For the first time it passes but when I run tests for the second time, it fails.

@hub33k hub33k self-assigned this Jul 30, 2020
@Dumluregn
Copy link
Collaborator Author

It seems the tests pass on FF if the browser is focused and fail otherwise. Could you guys check if that's true for you? @jacekbogdanski @hub33k

@hub33k
Copy link
Contributor

hub33k commented Jul 30, 2020

Yes, these tests fails for me when FF is not focused.

@f1ames
Copy link
Contributor

f1ames commented Jul 31, 2020

Let's leave it for now since it passes on CI.

@Dumluregn Dumluregn removed this from the 1.2.3 milestone Aug 17, 2020
@jacekbogdanski
Copy link
Member

jacekbogdanski commented Dec 14, 2020

I see that these tests are failing for me know just regularly:
image

(4 of them based on afterPaste event)

Edit: I didn't notice #119 (comment) and indeed that's the troubling part.

@Comandeer
Copy link
Member

Seems like these tests always fail now 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. status:confirmed An issue confirmed by the development team. type:failingtest A failing test.
Projects
None yet
Development

No branches or pull requests

5 participants