Fix e2e tests #122
Merged
Fix e2e tests #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dumluregn
requested changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing tests are partially caused by protractor/selenium upstreams, i.e.
angular/protractor#2019
angular/protractor#3196
and the fact that CKEditor 4 updates its content asynchronously. I've provided as a simple fix for the issue, but it requires resigning from sending special keystrokes like bold which also are handled incorrectly. Those keystrokes don't seem to be important for test validation.
Form issue is caused by an invalid editable query where it's embedded inside an iframe. Instead of doing some query gymnastic, I've just changed the sample to use
divareaeditor.Closes #118