Update deps #61
Update deps #61
Conversation
There was a problem hiding this comment.
Generally, looks good 👍
One thing to check - I have update CI to run tests on IE11 too (not sure why we haven't done this earlier) and it was passing nicely (only one tests failing same way as for Edge) - https://travis-ci.org/ckeditor/ckeditor4-angular/builds/611462712#L305:
After rebasing this PR, it seems there is some issue on IE11, more tests are failing (or rather throws some errors) - https://travis-ci.org/ckeditor/ckeditor4-angular/builds/611467093#L414:
Could you investigate this case? Quick search gives these one threads on SO - https://stackoverflow.com/questions/46790493/pace-js-not-working-in-ie-11, but I'm not sure if it will be helpful.
|
The reason for failing test for IE11 were missing polyfills. I didn't bother to add them before as they were unnecessary for CKEditor, but turned out to be relevant here - we need polyfills for both tests using I wanted to mention one more thing. I see that updating |
…ect after updating deps (core-js).
|
Rebased onto latest |
There was a problem hiding this comment.
Ok, I see now CI is green 💚 (pushed small fix with increased timeout since one tests is randomly failing on Edge/IE11)
I have checked with Angular 5 project and it looks good. Anyway, good catch with this issue 👍 Btw. there is a nice SO answer how to test with locally build package - https://stackoverflow.com/a/53794086.
Updated deps and devdeps according to https://david-dm.org/ckeditor/ckeditor4-angular and https://david-dm.org/ckeditor/ckeditor4-angular?type=dev. TypeScript was only updated to version
3.5.3as this is what Angular 8 allows (Angular 9 will require TS3.6).There were some issues to fix, primarily in unit tests, but they work fine now - the biggest change was rewriting test
should create editor with CKEDITOR.${method}as if I understand this comment correctly it couldn't work the old way anymore.e2e tests are currently broken as reported in #60.
Closes #32.
Closes #52.