Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend bind with possibility to pass arguments for bound functions #2862

Closed
wants to merge 0 commits into from
Closed

Extend bind with possibility to pass arguments for bound functions #2862

wants to merge 0 commits into from

Conversation

msamsel
Copy link
Contributor

@msamsel msamsel commented Feb 26, 2019 •
edited by jacekbogdanski
Loading

What is the purpose of this pull request?

New feature

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

Proposed changelog entry for this PR

* [#3247](https://github.com/ckeditor/ckeditor-dev/issues/3247): Extended [`CKEditor.tools.bind`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_tools.html#method-bind) method, to accept arguments for bound functions.

Closes #3247

msamsel pushed a commit that referenced this pull request Feb 26, 2019
Revert "Proviede possibility to bind also arguments to function not o…
ca47c70 
…nly context with CKEDITOR.tools.bind"

Functionality separates to own PR #2862.

This reverts commit 7383b2d.
@msamsel msamsel mentioned this pull request Feb 26, 2019
Merged
2 tasks
f1ames pushed a commit that referenced this pull request Mar 8, 2019
@f1ames
Revert "Proviede possibility to bind also arguments to function not o…
36b2935 
…nly context with CKEDITOR.tools.bind"

Functionality separates to own PR #2862.

This reverts commit 7383b2d.
ad1992 pushed a commit to interviewstreet/ckeditor-dev that referenced this pull request May 15, 2019
@ad1992
Revert "Proviede possibility to bind also arguments to function not o…
c36b641 
…nly context with CKEDITOR.tools.bind"

Functionality separates to own PR ckeditor#2862.

This reverts commit 7383b2d.
This was referenced Jul 5, 2019
Merged
Closed
@jacekbogdanski jacekbogdanski self-assigned this Jul 5, 2019
@jacekbogdanski
Copy link
Member

jacekbogdanski commented Jul 5, 2019 •
edited
Loading

Something very weird happened here as this PR has been automatically closed by GH after rebasing to the latest major. Nevertheless, I will recover this PR with the correct branch time (t/3247).

Extracted into #3249

@jacekbogdanski jacekbogdanski removed their assignment Jul 5, 2019
@jacekbogdanski jacekbogdanski mentioned this pull request Jul 5, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CKEDITOR.tools.bind helper
2 participants
@msamsel @jacekbogdanski