Underline

[ssougnez]

Hello,

this question can seem a bit stupid but I was wondering why there is no "underline" button in this package. Is it a specific challenge or were "bold" and "italic" just a test to see if it works?

If it's the later and if I'm able to create an underline command (based on the bold one, it shouldn't be too complicated), is it possible for me to contribute to the project? (Sorry I'm not used to the contributing part of Github).

Thanks

[szymonkups]

Hello @ssougnez.
We've created Editor Recommendations project where editing features are described in much detail. There is a GitHub repository where discussion on each feature is being made. You can find there a proper explanation why underline feature is not included together with other basic styles: ckeditor/editor-recommendations#4.

[Reinmar]

The discussion under Editor Recommendations explains why it's unlikely that we'll add this feature to standard presets and build(s). Basically, the ER project was meant to define how the most typical article editor should look like and the underline feature was (so far) identified as not very important one.

However, this doesn't mean that we don't want to have underline, strike through or sub/sup in basic-styles. We just haven't added them yet.

We don't have contributing guide yet, so I can't direct you to some resource, but of course, we do accept PRs. You'll need to start from checking how our development environment works, fork the basic-styles package and prepare a PR.

The underline feature will be a copy of existing styles. And I think that we have the icon prepared somewhere (cc @oleq?).

[Reinmar]

BTW, I think that underline and strike through are the last easy to add styles. Sub/sup is a bit trickier because there's a question how should applying one over the other behave. And there's also <code> which might not be yet considered during rendering spaces (DomConverter needs to handle spaces inside it differently than normally).

[oleq]

The underline feature will be a copy of existing styles. And I think that we have the icon prepared somewhere (cc @oleq?).

Ready and waiting.