T/51: Underline #54
T/51: Underline #54
Conversation
|
You need to update |
| const editor = this.editor; | ||
| const t = editor.t; | ||
| const command = editor.commands.get( 'underline' ); | ||
| const keystroke = 'CTRL+U'; |
There was a problem hiding this comment.
I'm not sure about this. Does CKE4 have some shortcut? Is it common for Ctrl+U to make underline? cc @oleq @Comandeer
There was a problem hiding this comment.
Yes, there's shortcut for it in CKE4 – Ctrl+U. The same shortcut is also available in Word, so it's probably safe to suppose that it's a de facto standard.
There was a problem hiding this comment.
In Pages CMD+U also works as I expected (makes underline).
Done in e14259d. Another question related to translation – should I do anything with translations files? |
Nope. Uploading and downloading data to/from Transifex is done by me. |
src/underlineengine.js
Outdated
| */ | ||
|
|
||
| /** | ||
| * @module basic-styles/underline |
There was a problem hiding this comment.
@module basic-styles/underlineengine
Suggested merge commit message (convention)
Feature: Introduced the
Underlineplugin. Closes ckeditor/ckeditor5#5545.