Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Set UI button as toggleable #40

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Set UI button as toggleable #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e070c80
Set buttons as toggleable and add unit test checking it.
Aug 9, 2019
fa34b49
Merge branch 'master' into t/ckeditor5/1403
oleq Aug 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/blockquoteui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ export default class BlockQuoteUI extends Plugin {
buttonView.set( {
label: t( 'Block quote' ),
icon: quoteIcon,
tooltip: true
tooltip: true,
isToggleable: true
} );

// Bind button model to command.
Expand Down
1 change: 1 addition & 0 deletions tests/blockquoteui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ describe( 'BlockQuoteUI', () => {
expect( button ).to.have.property( 'label', 'Block quote' );
expect( button ).to.have.property( 'icon' );
expect( button ).to.have.property( 'tooltip', true );
expect( button ).to.have.property( 'isToggleable', true );
} );

it( 'has isOn bound to command\'s value', () => {
Expand Down