Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/ckeditor5/1341 #18

Merged
merged 2 commits into from
Jan 22, 2019
Merged

T/ckeditor5/1341 #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4af60d7
Add memory leak test.
jodator Jan 16, 2019
87b70fa
Add missing ckeditor5-core dependency.
jodator Jan 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"@ckeditor/ckeditor5-basic-styles": "^10.1.0",
"@ckeditor/ckeditor5-block-quote": "^10.1.1",
"@ckeditor/ckeditor5-ckfinder": "^10.0.0",
"@ckeditor/ckeditor5-core": "^11.1.0",
"@ckeditor/ckeditor5-dev-utils": "^11.0.1",
"@ckeditor/ckeditor5-dev-webpack-plugin": "^7.0.1",
"@ckeditor/ckeditor5-easy-image": "^10.0.4",
Expand Down
9 changes: 8 additions & 1 deletion tests/ckeditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import DecoupledEditor from '../src/ckeditor';
import BaseDecoupledEditor from '@ckeditor/ckeditor5-editor-decoupled/src/decouplededitor';
import { describeMemoryUsage, testMemoryUsage } from '@ckeditor/ckeditor5-core/tests/_utils/memory';

describe( 'DecoupledEditor build', () => {
let editor, editorData, editorElement;
Expand All @@ -25,7 +26,7 @@ describe( 'DecoupledEditor build', () => {
editor = null;
} );

describe( 'buid', () => {
describe( 'build', () => {
it( 'contains plugins', () => {
expect( DecoupledEditor.builtinPlugins ).to.not.be.empty;
} );
Expand Down Expand Up @@ -59,6 +60,12 @@ describe( 'DecoupledEditor build', () => {
} );
} );

describeMemoryUsage( () => {
testMemoryUsage(
'should not grow on multiple create/destroy',
() => DecoupledEditor.create( document.querySelector( '#mem-editor' ) ) );
} );

function test( getEditorDataOrElement ) {
describe( 'create()', () => {
beforeEach( () => {
Expand Down