This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Internal: Disabled clipboardInput when editor is read-only.
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oskarwrobel, why is it needed for ckeditor/ckeditor5-image#209? It seems to fix a different issue (and I'm not sure I know what issue). |
Reinmar
commented
Jun 4, 2018
| @@ -194,6 +194,29 @@ describe( 'Clipboard feature', () => { | |||
| sinon.assert.notCalled( spy ); | |||
| } ); | |||
|
|
|||
| it( 'stops `clipboardInput` event on highest priority when editor is read-only', () => { | |||
There was a problem hiding this comment.
Why? Why wasn't that old return; enough?
|
OK, I can see that without this change image's tests fail. Still, I'd like to know why :D |
|
I created a dedicated issue https://github.com/ckeditor/ckeditor5-clipboard/issues/48. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Disabled
clipboardInputwhen editor is read-only. Closes ckeditor/ckeditor5#2679.Additional information
Part of ckeditor/ckeditor5-image#209.