Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Change CloudServices plugin to a context plugin. #23

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Change CloudServices plugin to a context plugin. #23

merged 3 commits into from
Jan 29, 2020

Conversation

oskarwrobel
Copy link
Contributor

@oskarwrobel oskarwrobel commented Dec 2, 2019

Suggested merge commit message (convention)

Internal: Changed CloudServices plugin to a context plugin. Part of ckeditor/ckeditor5#5891.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@oskarwrobel oskarwrobel requested a review from scofalik December 3, 2019 16:18
@oskarwrobel oskarwrobel changed the title Change CloudServices plugin to the context plugin. Change CloudServices plugin to a context plugin. Dec 3, 2019
Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing tests that this plugin can be initialized in a context of a context 🧸

@Reinmar
Copy link
Member

Reinmar commented Jan 27, 2020

Waiting for tests here...

@scofalik
Copy link
Contributor

I've udated the tests.

@scofalik
Copy link
Contributor

I see there are some conflicts, though...

@scofalik scofalik self-requested a review January 28, 2020 09:20
@Reinmar Reinmar merged commit 12ca96d into master Jan 29, 2020
@Reinmar Reinmar deleted the context branch January 29, 2020 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants