-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default theme #105
Comments
What are the questions that we want to answer here? I mean – are we meant to discuss (spacing, colors, etc.) the designs already or sth else still? |
@Reinmar See |
OK, changing the title to "The problems to consider" makes this clear. |
Yes, you were right. Also note that this is the beginning – there will be more problems in the future. |
Overall very nice. Tabs could be even simpler, perhaps just heavy over or underline. Dark title bar need not be so dark if tabs have no background. The lighter color can be the top bar background. It looks a bit heavy now. My personal preference is larger and lighter weight for titles. |
This looks like a big improvement. Have you considered moving the labels above the form fields. This would improve the usability and provide more space for UI elements.
Keep up the good work |
The tabbed interface looks great 👍 For the dialogs consider to use more wide space for the form elements, the more you see the better as @georgephillips also points out. |
@georgephillips Good point, thanks! |
I've been just reviewing the dropdown component and found the dropdown styling very confusing. It's so white in relation to totally unmarked buttons that they look like active all the time. I think that the styling should be very similar, if not identical. |
I don't think so, @Reinmar. It was a conscious design decision. Take a look on the interface of popular text processors like LibreOffice Writer or MS Word 2016. It's a common practice that dropdowns and other complex controls in the toolbar are slightly different than the rest of the interface. |
Hm.. you're right. But:
But most importantly, it just looks odd when you have just couple of buttons. The below screenshot is of course an extreme situation when you have exactly three items and each of them is different. But we should take such case into consideration. (of course margins are missing and the dropdown button is too big due to the border, but this is a different story) |
BTW when I look at designs like this https://twitter.com/steipete/status/735377624265072641 I start to think that perhaps we should adopt a single convention and follow it closely. I think that perhaps we've been trying to be too innovative. For many aspects that makes sense, and the UX in some sense will be one of them, but design not necessarily. |
sorry if this is the wrong place to ask: since html has no implements a concept of physical page (A4 paper), ckeditor 5 will provide anything that helps to implement the editor with concept of physical page, like google docs, ms office online do? |
Thanks for asking. That's a topic for a separate ticket: #147 |
Cleaning up old discussions. See #186. |
Note: This is an umbrella issue, a heart of discussion around themes in CKE5. The aim is to avoid fragmentation and confusion about the mockups.
The architecture of themes is discussed in a separate issue.
Overview
CKEditor 5 needs a new, default theme.
Problems to consider
Mockups
These mockups follow the Implementations document. This is the first attempt to take the ongoing UX discussion to the next level, an entry point to further discussion.
Classic interface
Tabbed interface
Menu
Dialogs
Inline editing
Fullpage
The text was updated successfully, but these errors were encountered: