Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default theme: rounded corners #113

Closed
oleq opened this issue Jan 28, 2016 · 6 comments
Closed

Default theme: rounded corners #113

oleq opened this issue Jan 28, 2016 · 6 comments

Comments

@oleq
Copy link
Member

oleq commented Jan 28, 2016

Though it's probably just a single variable in the global Less (or whichever preprocessor) file, default theme must be consistent in terms of rounded corners. There are few places where rounded corners could possibly be used, like :

  • dialogs
  • panels
  • buttons
  • inputs

image

Are rounded corners OK or maybe a little bit out of fashion? What is the best for easy integration with apps and web pages?

@Reinmar
Copy link
Member

Reinmar commented Jan 28, 2016

Are rounded corners OK or maybe a little bit out of fashion?

Depends on who you're asking. I'd say currently they are out of fashion, so by default we can propose a theme without them. But making this a a LESS variable, you could easily switch to rounded corners, and some guys will like that.

@oleq
Copy link
Member Author

oleq commented Jan 28, 2016

I'd say currently they are out of fashion, so by default we can propose a theme without them.

I'd say exactly the same. We could create some sort of mixin (let's call it "box–mixin"), that, once extended, would bring some visual features to all relevant UI controls (dialogs, panels, buttons...).

@koleary
Copy link

koleary commented Feb 18, 2016

I would not say that rounded corners are "out-of-fashion." However, the radius of rounded corners, where they are used, is generally much smaller (3 or 4 px) and frameworks that don't have them by default still have them as a variable. For example look at Foundation 6.

I think that's a good model to follow. Do without them by default but build in an easy way to globally add them back.

@georgephillips
Copy link

I would argue that less rounding is better. a 2px border radius can go unnoticed in an interface and soften the element on the page. A larger border radius makes more of a statement which might conflict with page styles. If this was extracted into a css preprocessor variable it would be quite easy to change or remove.

@koleary
Copy link

koleary commented Feb 27, 2016

@georgephillips

+1

@Reinmar
Copy link
Member

Reinmar commented Apr 20, 2018

Cleaning up old discussions. See #186.

@Reinmar Reinmar closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants