Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack Plugin - replaceTCalls() should work on Windows #7042

Closed
pomek opened this issue Oct 12, 2017 · 0 comments
Closed

Webpack Plugin - replaceTCalls() should work on Windows #7042

pomek opened this issue Oct 12, 2017 · 0 comments
Assignees
@pomek @ma2ciek
Labels
package:dev type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 13

Comments

@pomek
Copy link
Member

pomek commented Oct 12, 2017

The problem occurred when @onurozkan wanted to build an editor on Windows (https://github.com/ckeditor/ckeditor5-build-classic/issues/26).

The build does not work on Windows because regexp used in replaceTCalls() function works on Unix systems only.

https://github.com/ckeditor/ckeditor5-dev/blob/b6c059b6d8b6b840cdbd85b703564ca7521fe811/packages/ckeditor5-dev-webpack-plugin/lib/replacetcalls.js#L29

We should detect which separator path should be used: / for Unix, \ for Windows.

I remember we did it a few months ago when we were introducing Karma.
@ma2ciek ma2ciek self-assigned this Oct 16, 2017
pomek referenced this issue in ckeditor/ckeditor5-dev Oct 18, 2017
@pomek
Merge pull request #299 from ckeditor/t/297
7e61a1f 
Fix: Fixed paths in webpack-plugin for Windows environment. Closes #297.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-dev May 18, 2020
@mlewand mlewand added this to the iteration 13 milestone May 18, 2020
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:dev labels May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

@ma2ciek ma2ciek

Labels
package:dev type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 13
Development

No branches or pull requests
3 participants
@pomek @ma2ciek @mlewand