-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Build #2153
Windows Build #2153
Comments
Hey! How does it break now? It may be something simple, but we didn't test it on Windows yet so I really don't know. As for Windows support in general, I guess it's a high time that we provide it for at least the builds. Support for the entire development environment is something bigger and far less developers will need it so it may wait (I hope). |
About half of the year ago I tested our test tools on Windows and one issue which I found was invalid regexp for Windows. I guess the same problem can occur here. When we made a config file, we assumed that Webpack will be executed on Unix. So regexps have been written for Unix paths. If we fix the regexp for Windows, most probably the problem won't occur anymore. It's worth checking. |
Tried few things. This is the result of default build as "npm run build"
Later i changed create entry file script to this; "node bin/create-entry-file.js".
And eventually i checked shell script, saw webpack, and changed "build-ckeditor" command to "webpack". This is the the error i got.
I think we are now in same page with @pomek |
We can easily skip first 2 problems just by changing these lines. But cgywin required for shell script. Tried on Mac and Windows, worked well.
So only problem probably regexp. |
Looks like the problem with regexps. It should be an easy-to-solve thing. Instead of |
And we could detect whether use Unix / Windows separator path in regexp. @Reinmar, WDYT? |
changed line to this, solved the problem. const pathToCoreTranslationPackage = result.match( /.+\\ckeditor5-core/ )[ 0 ]; |
@onurozkan, great! Thanks for the details. Could you make a PR to this package with your changes? We'll handle the regexp in https://github.com/ckeditor/ckeditor5-dev/tree/master/packages/ckeditor5-dev-webpack-plugin and see if something's left. @pomek, could you look into it? |
Yea. |
Part of the ticket related to Webpack plugin has been reported here – https://github.com/ckeditor/ckeditor5-dev/issues/297. |
Fix: Build scripts will work on Windows. Closes #26.
I applied changes from ckeditor/ckeditor5-build-classic#27 to other builds repositories: |
Thanks for the PR! And thanks @pomek for merging it. The other issue that we need to solve: https://github.com/ckeditor/ckeditor5-dev/issues/297. EDIT: Oops, I haven't noticed you linked to it already, @pomek. |
I've just released @ckeditor/ckeditor5-dev-webpack-plugin@2.0.20 – this version should fix the issue. |
Hello,
Currently build scripts does not work on Windows.
Is there any plan for Windows support soon? or any hacks/tricks for now?
Thanks.
The text was updated successfully, but these errors were encountered: