Use Yarn on Travis #453
Use Yarn on Travis #453
Conversation
| @@ -2,15 +2,18 @@ | |||
|
|
|||
| set -e | |||
|
|
|||
| npm install mgit2 lerna@^2.0.0-rc.1 eslint-config-ckeditor5 karma-coveralls@^1.1.2 | |||
| npm install -g mgit2 | |||
There was a problem hiding this comment.
AFAIR Yarn will remove this dependency (during yarn install) because it isn't listed in package.json.
There was a problem hiding this comment.
In CF we have the mgit with its version listed in the package.json. Not sure if it will work here though.
There was a problem hiding this comment.
We were avoiding relying on deps in package.json because doing npm i and then lerna bootstrap would install the same deps twice (so it'd be slow). That's why we had the deps listed here. I think it's still a thing here because e.g. karma-coverals is not needed in all the packages in our local dev envs. It's only needed on CI. And it's the opposite with the other dependencies – you don't want to install them from npm.
There was a problem hiding this comment.
karma-coverals isn't a dep of any of ckeditor5-*. I added it as a dep of ckeditor5-dev-tests because coveralls is a part of the testing environment.
Co-Authored-By: pomek <pomek@users.noreply.github.com>
Suggested merge commit message (convention)
Other: Changed scripts in the
@ckeditor/ckeditor5-dev-testspackage after switching development environment to Yarn. See ckeditor/ckeditor5#1214.