Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i/611: Configured stylelint to enforce CSS indentation using tabs and hsl() colors #612

Merged
merged 3 commits into from
Apr 15, 2020
Merged

i/611: Configured stylelint to enforce CSS indentation using tabs and hsl() colors #612

merged 3 commits into from
Apr 15, 2020

Conversation

oleq
Copy link
Member

@oleq oleq commented Apr 9, 2020 •
edited
Loading

Suggested merge commit message (convention)

Other: Configured stylelint to enforce CSS indentation using tabs and hsl() colors. Closes #611.

Additional information

sub-PRs in v5 that fix stylelint errors (they can be merged regardless fo this PR):

Let's make sure we release stylelint-config-ckeditor5 when this is all done (cc @pomek).

@coveralls
Copy link

coveralls commented Apr 9, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 91.604% when pulling cc6f390 on i/611 into 4108446 on master.

@oleq oleq changed the title i/611: Configured stylelint to enforce CSS indentation using tabs i/611: Configured stylelint to enforce CSS indentation using tabs and hsl() colors Apr 9, 2020
@oleq oleq requested review from panr and pomek April 9, 2020 15:18
pomek
pomek approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

panr
panr approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@panr panr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

panr
panr approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@panr panr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@oleq oleq merged commit 54a3ba1 into master Apr 15, 2020
@oleq oleq deleted the i/611 branch April 15, 2020 09:41
@oleq
Copy link
Member Author

oleq commented Apr 15, 2020

@pomek Can you please release the package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomek pomek pomek approved these changes

@panr panr panr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend stylelint rules for tab indentation and color format
4 participants
@oleq @coveralls @panr @pomek