Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the translations:download tools more generic #641

Merged
merged 5 commits into from
Jun 9, 2020
Merged

Conversation

ma2ciek
Copy link
Contributor

@ma2ciek ma2ciek commented May 21, 2020

Suggested merge commit message (convention)

Feature (env): Translation tools can handle external packages outside the CKEditor 5 repository. Closes ckeditor/ckeditor5#6635.


Additional information

getToken returns now correctly a promise to a token instead a promise to { token }.

@ma2ciek ma2ciek changed the title WIP Made the translations:download script more generic. WIP Made the translations:download tools more generic. May 21, 2020
@coveralls
Copy link

coveralls commented Jun 7, 2020

Coverage Status

Coverage decreased (-0.3%) to 88.044% when pulling 01b94ca on i/ckeditor5/6635 into 010abb7 on master.

@ma2ciek ma2ciek changed the title WIP Made the translations:download tools more generic. Made the translations:download tools more generic Jun 8, 2020
@ma2ciek
Copy link
Contributor Author

ma2ciek commented Jun 9, 2020

@pomek, could you look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tools for downloading translations and uploading POT files customizable
3 participants