Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for not adding a new line while parsing data:image CSS definitions. #966

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

pszczesniak
Copy link
Contributor

@pszczesniak pszczesniak commented Jul 4, 2024

Suggested merge commit message (convention)

Fix: Should not corrupt the CSS code during splitting CSS into editor and content files. See ckeditor/ckeditor5#16670.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

Coverage Status

coverage: 90.624%. remained the same
when pulling b9b37cd on css-data-image-new-line-fix
into e0cccdf on master.

@pszczesniak pszczesniak requested a review from filipsobol July 4, 2024 12:28
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
@coveralls
Copy link

Coverage Status

coverage: 90.624%. remained the same
when pulling 130798c on css-data-image-new-line-fix
into e0cccdf on master.

@pszczesniak pszczesniak requested a review from filipsobol July 4, 2024 13:13
@pszczesniak pszczesniak merged commit e196d78 into master Jul 4, 2024
2 checks passed
@pszczesniak pszczesniak deleted the css-data-image-new-line-fix branch July 4, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants