BalloonEditor.create() will throw an error, when textarea element is used. #33

msamsel · 2019-05-15T08:06:46Z

Suggested merge commit message (convention)

Feature: BalloonEditor.create() will throw an error, when textarea element is used.

Additional information

PR requires: Throw an error when user tries to use inappropriate editor over textarea ckeditor5-core#173

Check if balloon editor throws an error when is created inside textarea.

coveralls · 2019-05-15T08:10:34Z

Coverage remained the same at 100.0% when pulling 6624119 on t/ckeditor5/1591 into d5c4162 on master.

This reverts commit 2fe57a7.

Mateusz Samsel added 3 commits May 7, 2019 15:46

Prevent of creating balloon editor inside textarea.

2fe57a7

Remove failing test, which is not valid any longer.

ef8cb57

Add unit test

1660072

Check if balloon editor throws an error when is created inside textarea.

msamsel mentioned this pull request May 15, 2019

Throw an error when user tries to use inappropriate editor over textarea ckeditor/ckeditor5-core#173

Merged

Mateusz Samsel added 4 commits May 16, 2019 14:01

Revert "Prevent of creating balloon editor inside textarea."

4aeab07

This reverts commit 2fe57a7.

Use assert method to prevent of editor initialization in textarea.

4a0f39d

Improve test to match exactly thrown error.

81ca239

Move assert check directly to child class.

6624119

jodator merged commit 83552e2 into master Jun 12, 2019

jodator deleted the t/ckeditor5/1591 branch June 12, 2019 13:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BalloonEditor.create() will throw an error, when textarea element is used. #33

BalloonEditor.create() will throw an error, when textarea element is used. #33

msamsel commented May 15, 2019 •

edited

Loading

coveralls commented May 15, 2019 •

edited

Loading

BalloonEditor.create() will throw an error, when textarea element is used. #33

BalloonEditor.create() will throw an error, when textarea element is used. #33

Conversation

msamsel commented May 15, 2019 • edited Loading

Suggested merge commit message (convention)

Additional information

coveralls commented May 15, 2019 • edited Loading

msamsel commented May 15, 2019 •

edited

Loading

coveralls commented May 15, 2019 •

edited

Loading