-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the name of the main file to classiceditor
to reflect class name
#2218
Closed
Labels
package:editor-classic
type:task
This issue reports a chore (non-production change) and other types of "todos".
Milestone
Comments
This change should also be done in the two other editors and perhaps in more places (such as the builds and many tests). |
oleq
referenced
this issue
in ckeditor/ckeditor5-basic-styles
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-block-quote
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-adapter-ckfinder
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-autoformat
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-build-classic
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-clipboard
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-enter
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-heading
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-engine
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-image
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-link
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-list
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-paragraph
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-essentials
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-undo
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-ui
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-typing
Jun 14, 2017
oleq
referenced
this issue
in ckeditor/ckeditor5-upload
Jun 14, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-block-quote
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-adapter-ckfinder
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-autoformat
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-basic-styles
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-build-classic
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-clipboard
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-editor-classic
Jun 19, 2017
…the naming convention. Closes #41. BREAKING CHANGE: The `classic.js` file containing `ClassicEditor` class has been renamed to `classiceditor.js`.
szymonkups
referenced
this issue
in ckeditor/ckeditor5-enter
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-image
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-heading
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-engine
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-link
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-list
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-paragraph
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-essentials
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-typing
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-undo
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-ui
Jun 19, 2017
szymonkups
referenced
this issue
in ckeditor/ckeditor5-upload
Jun 19, 2017
mlewand
added
status:confirmed
type:task
This issue reports a chore (non-production change) and other types of "todos".
package:editor-classic
labels
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package:editor-classic
type:task
This issue reports a chore (non-production change) and other types of "todos".
The file is now named
classic.js
in order to better work withckeditor5-editor-classic
(it matches the last word and tries to follow the short feature naming pattern wherelink
==link/link
). However, that's as confusing as the inconsistent order inckeditor5-editor-classic/classiceditor.js
, so, since the shortened feature naming is gone, it's better to just stick to the general naming pattern where file name reflects the class name.The text was updated successfully, but these errors were encountered: