This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Allow to pass initial data to the editor constructor #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
reviewed
May 17, 2018
src/inlineeditor.js
Outdated
| * import ... | ||
| * | ||
| * InlineEditor | ||
| * .create( '<p>Hello world!</p>, { |
|
I miss a slightly better explanation what you can find in Apart from that, all LGTM. |
pomek
approved these changes
Jun 5, 2018
6 tasks
…hUI interface (added editor.element property).
Reinmar
reviewed
Jul 3, 2018
src/inlineeditor.js
Outdated
| @@ -86,7 +97,7 @@ export default class InlineEditor extends Editor { | |||
| this.ui.destroy(); | |||
|
|
|||
| return super.destroy() | |||
| .then( () => setDataInElement( this.element, data ) ); | |||
| .then( () => setDataInElement( this.sourceElement, data ) ); | |||
There was a problem hiding this comment.
What if there's no source element?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Editor can be created with initial data passed to the constructor. Closes ckeditor/ckeditor5#2271.
BREAKING CHANGE:
InlineEditor#elementis now available asInlineEditor#sourceElement. See ckeditor/ckeditor5#2882.Requires: ckeditor/ckeditor5-core#129