Apply suggestions from code review

Co-Authored-By: Piotrek Koszuliński <pkoszulinski@gmail.com>
ckeditor · Jul 25, 2019 · 76f8a51 · 76f8a51
1 parent b961330
commit 76f8a51
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/model/element.js b/src/model/element.js
@@ -113,7 +113,8 @@ export default class Element extends Node {
 	 * @returns {Boolean}
 	 */
 	is( type, name = null ) {
-		const cutType = type.replace( 'model:', '' );
+		const cutType = type.replace( /^model:/, '' );
+
 		if ( !name ) {
 			return cutType == 'element' || cutType == this.name || super.is( type );
 		} else {

diff --git a/src/view/attributeelement.js b/src/view/attributeelement.js
@@ -128,7 +128,8 @@ export default class AttributeElement extends Element {
 	 * @inheritDoc
 	 */
 	is( type, name = null ) {
-		const cutType = type && type.replace( 'view:', '' );
+		const cutType = type && type.replace( /^view:/, '' );
+
 		if ( !name ) {
 			return cutType == 'attributeElement' || super.is( type );
 		} else {