Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Remove unit test for classes without 'is()' method.
Browse files Browse the repository at this point in the history
  • Loading branch information
Mateusz Samsel committed Jun 26, 2019
1 parent e547b3f commit b73f43d
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 162 deletions.
15 changes: 0 additions & 15 deletions tests/view/document.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,21 +37,6 @@ describe( 'Document', () => {
} );
} );

describe( 'is()', () => {
it( 'should return true for "document"', () => {
expect( viewDocument.is( 'document' ) ).to.be.true;
expect( viewDocument.is( 'view:document' ) ).to.be.true;
} );

it( 'should return false for incorrect values', () => {
expect( viewDocument.is( 'model' ) ).to.be.false;
expect( viewDocument.is( 'model:document' ) ).to.be.false;
expect( viewDocument.is( 'node' ) ).to.be.false;
expect( viewDocument.is( 'view:node' ) ).to.be.false;
expect( viewDocument.is( 'element', 'text' ) ).to.be.false;
} );
} );

describe( 'getRoot()', () => {
it( 'should return "main" root', () => {
createViewRoot( viewDocument, 'div', 'main' );
Expand Down
15 changes: 0 additions & 15 deletions tests/view/domconverter/domconverter.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,6 @@ describe( 'DomConverter', () => {
} );
} );

describe( 'is()', () => {
it( 'should return true for "domConverter"', () => {
expect( converter.is( 'domConverter' ) ).to.be.true;
expect( converter.is( 'view:domConverter' ) ).to.be.true;
} );

it( 'should return false for incorrect values', () => {
expect( converter.is( 'view' ) ).to.be.false;
expect( converter.is( 'model:domConverter' ) ).to.be.false;
expect( converter.is( 'node' ) ).to.be.false;
expect( converter.is( 'view:node' ) ).to.be.false;
expect( converter.is( 'element', 'text' ) ).to.be.false;
} );
} );

describe( 'focus()', () => {
let viewEditable, domEditable, domEditableParent, viewDocument;

Expand Down
23 changes: 0 additions & 23 deletions tests/view/downcastwriter/is.js

This file was deleted.

26 changes: 0 additions & 26 deletions tests/view/matcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -442,30 +442,4 @@ describe( 'Matcher', () => {
expect( matcher.getElementName() ).to.be.null;
} );
} );

describe( 'is', () => {
let matcher;

before( () => {
matcher = new Matcher( 'div' );
} );

it( 'should return true for "matcher"', () => {
expect( matcher.is( 'matcher' ) ).to.be.true;
expect( matcher.is( 'view:matcher' ) ).to.be.true;
} );

it( 'should return false for other accept values', () => {
expect( matcher.is( 'rootElement' ) ).to.be.false;
expect( matcher.is( 'containerElement' ) ).to.be.false;
expect( matcher.is( 'element' ) ).to.be.false;
expect( matcher.is( 'p' ) ).to.be.false;
expect( matcher.is( 'text' ) ).to.be.false;
expect( matcher.is( 'textProxy' ) ).to.be.false;
expect( matcher.is( 'attributeElement' ) ).to.be.false;
expect( matcher.is( 'uiElement' ) ).to.be.false;
expect( matcher.is( 'emptyElement' ) ).to.be.false;
expect( matcher.is( 'documentFragment' ) ).to.be.false;
} );
} );
} );
21 changes: 0 additions & 21 deletions tests/view/renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,27 +40,6 @@ describe( 'Renderer', () => {
renderer.domDocuments.add( document );
} );

describe( 'is()', () => {
it( 'should return true for "renderer"', () => {
expect( renderer.is( 'renderer' ) ).to.be.true;
expect( renderer.is( 'view:renderer' ) ).to.be.true;
} );

it( 'should return false for other accept values', () => {
expect( renderer.is( 'rootElement' ) ).to.be.false;
expect( renderer.is( 'containerElement' ) ).to.be.false;
expect( renderer.is( 'element' ) ).to.be.false;
expect( renderer.is( 'p' ) ).to.be.false;
expect( renderer.is( 'text' ) ).to.be.false;
expect( renderer.is( 'textProxy' ) ).to.be.false;
expect( renderer.is( 'attributeElement' ) ).to.be.false;
expect( renderer.is( 'uiElement' ) ).to.be.false;
expect( renderer.is( 'emptyElement' ) ).to.be.false;
expect( renderer.is( 'documentFragment' ) ).to.be.false;
expect( renderer.is( 'model:renderer' ) ).to.be.false;
} );
} );

describe( 'markToSync', () => {
let viewRoot;

Expand Down
27 changes: 0 additions & 27 deletions tests/view/treewalker.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,33 +70,6 @@ describe( 'TreeWalker', () => {
} );
} );

describe( 'is()', () => {
let treeWalker;

beforeEach( () => {
treeWalker = new TreeWalker( { startPosition: rootBeginning } );
} );

it( 'should return true for "treeWalker"', () => {
expect( treeWalker.is( 'treeWalker' ) ).to.be.true;
expect( treeWalker.is( 'view:treeWalker' ) ).to.be.true;
} );

it( 'should return false for other accept values', () => {
expect( treeWalker.is( 'rootElement' ) ).to.be.false;
expect( treeWalker.is( 'containerElement' ) ).to.be.false;
expect( treeWalker.is( 'element' ) ).to.be.false;
expect( treeWalker.is( 'p' ) ).to.be.false;
expect( treeWalker.is( 'text' ) ).to.be.false;
expect( treeWalker.is( 'textProxy' ) ).to.be.false;
expect( treeWalker.is( 'attributeElement' ) ).to.be.false;
expect( treeWalker.is( 'uiElement' ) ).to.be.false;
expect( treeWalker.is( 'emptyElement' ) ).to.be.false;
expect( treeWalker.is( 'documentFragment' ) ).to.be.false;
expect( treeWalker.is( 'model:treeWalker' ) ).to.be.false;
} );
} );

describe( 'iterate from start position `startPosition`', () => {
let expected;

Expand Down
21 changes: 0 additions & 21 deletions tests/view/upcastwriter.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,27 +34,6 @@ describe( 'UpcastWriter', () => {
view = dataprocessor.toView( html );
} );

describe( 'is()', () => {
it( 'should return true for "upcastWriter"', () => {
expect( writer.is( 'upcastWriter' ) ).to.be.true;
expect( writer.is( 'view:upcastWriter' ) ).to.be.true;
} );

it( 'should return false for other accept values', () => {
expect( writer.is( 'rootElement' ) ).to.be.false;
expect( writer.is( 'containerElement' ) ).to.be.false;
expect( writer.is( 'element' ) ).to.be.false;
expect( writer.is( 'p' ) ).to.be.false;
expect( writer.is( 'text' ) ).to.be.false;
expect( writer.is( 'textProxy' ) ).to.be.false;
expect( writer.is( 'attributeElement' ) ).to.be.false;
expect( writer.is( 'uiElement' ) ).to.be.false;
expect( writer.is( 'emptyElement' ) ).to.be.false;
expect( writer.is( 'documentFragment' ) ).to.be.false;
expect( writer.is( 'model:renderer' ) ).to.be.false;
} );
} );

describe( 'createDocumentFragment', () => {
it( 'should create empty document fragment', () => {
const df = writer.createDocumentFragment();
Expand Down
14 changes: 0 additions & 14 deletions tests/view/view/view.js
Original file line number Diff line number Diff line change
Expand Up @@ -475,20 +475,6 @@ describe( 'view', () => {
} );
} );

describe( 'is()', () => {
it( 'should return true for "view"', () => {
expect( view.is( 'view' ) ).to.be.true;
} );

it( 'should return false for incorrect values', () => {
expect( view.is( 'model' ) ).to.be.false;
expect( view.is( 'model:document' ) ).to.be.false;
expect( view.is( 'node' ) ).to.be.false;
expect( view.is( 'view:node' ) ).to.be.false;
expect( view.is( 'element', 'text' ) ).to.be.false;
} );
} );

describe( 'isFocused', () => {
it( 'should change renderer.isFocused too', () => {
expect( viewDocument.isFocused ).to.equal( false );
Expand Down

0 comments on commit b73f43d

Please sign in to comment.