-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Safari] Selection is locked in a nested editable #4192
Comments
Looks serious, how it is possible and how did we missed it? Why would the selection be rendered there? |
So many questions, so few answers. |
Could be related to #4188 |
TBH, I cannot reproduce it. I am using Safari version |
Do you try it in the docs? I can reproduce it even on https://ckeditor5.github.io Safari Version 11.0 (12604.1.38.1.7) |
Strange. I can constantly reproduce it. I even changed the way I click (mouse vs trackpad). Dunno. So, let's wait for other to reproduce it. |
We didn't :D #557. I will close the issue in the main repository. |
If you can reproduce it, can you go to file this._renderTimeoutId = setTimeout( () => document.render(), 0 ); to this._renderTimeoutId = setTimeout( () => document.render(), 100 ); And see if that helped? |
Okay for some reason I started to be able to reproduce it :O. I can confirm that the fix above does help. |
I also checked it and it works great 👍 |
Fix: Added a 50ms timeout after `Document#focus` event before rendering to be sure that selection changes are processed on Firefox and Safari. Closes ckeditor/ckeditor5#676. Closes #1157. Closes #1155. Closes #1153.
You can't leave a nested editable by clicking somewhere in editor's content outside of that nested editable because engine re-renders selection inside that nested editable:
I can reproduce it e.g. here: https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/examples/builds/classic-editor.html
The text was updated successfully, but these errors were encountered: