-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FF] Error after moving focus to the image caption using Tab #676
Comments
I've checked it on Chome and Firefox@59 and listed below some results.
I see, that in the In Chrome, both The I'll check whether this is not a problem with view selection. It actually works with a try-catch block, so it should be just a case of not set Selection. |
I see that shift + tab from the caption doesn't work at all in the latest FF. |
It looks like the It looks like we can increase the timeout in the: https://github.com/ckeditor/ckeditor5-engine/blob/7755349c190f08e3806ae562f094823c5db57088/src/view/observer/focusobserver.js#L38 to solve that issue as we can't ensure correct order in a different way. |
Can't we make the code more bulletproof? Selection changes should not depend on focus changes and vice versa. We could, of course, increase the timeout but it's hard to tell to what value. At some point the delay in which the editor reacts will be noticable but the editor might be still unstable in some specific cases on overloaded and slow devices. |
Sure, I'll talk with @szymonkups about other possibilities. But I guess, it's not gonna be easy. |
After a F2F talks, we agreed that using longer |
Fix: Added a 50ms timeout after `Document#focus` event before rendering to be sure that selection changes are processed on Firefox and Safari. Closes ckeditor/ckeditor5#676. Closes #1157. Closes #1155. Closes #1153.
π Is this a bug report or feature request? (choose one)
π» Version of CKEditor
1.0.0-alpha2
π Steps to reproduce
Heading 1
.β Expected result
Focus should move to the caption without error.
β Actual result
Focus moves to the caption and there is the error in the console.
π Other details that might be useful
Error
GIF
Browser: Firefox 57 (Quantum).
Note: I'm able to reproduce this issue also in Firefox 56.
The text was updated successfully, but these errors were encountered: