Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent adding inline filler to elements with contenteditable=false #4200

Closed
szymonkups opened this issue Oct 19, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1173
Closed

Prevent adding inline filler to elements with contenteditable=false #4200

szymonkups opened this issue Oct 19, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1173
Assignees
@szymonkups
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 13

Comments

@szymonkups
Copy link
Contributor

There are situations when browsers put selection inside contenteditable=false elements (https://github.com/ckeditor/ckeditor5-image/issues/19) and we render inline filler there. Block fillers are blocked by getFillerOffset() but inline fillers are not blocked in any way there.

The solution might be to block rendering it if the nearest ancestor with contenteditable attribute has it set to false.
@szymonkups szymonkups self-assigned this Oct 19, 2017
@pjasiun
Copy link

pjasiun commented Oct 19, 2017

This is strange because inline filler should be rendered only where the selection is. First of all, the collapsed selection should not be placed in not editable elements. Maybe we should fix the selection position to move it out of the not editable elements first?

@szymonkups
Copy link
Contributor Author

That was the first approach but here https://github.com/ckeditor/ckeditor5-image/issues/19#issuecomment-279407966 I described why this fails.

pjasiun referenced this issue in ckeditor/ckeditor5-engine Oct 30, 2017
Merge pull request #1173 from ckeditor/t/1170
07a01b1 
Fix: Prevent adding inline filler to non-editable content. Closes #1170.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 13 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 13
Development

Successfully merging a pull request may close this issue.

Prevent adding inline filler to non-editable content. ckeditor/ckeditor5-engine
3 participants
@pjasiun @szymonkups @mlewand