Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re–entering the link selection mode takes an additional key press #4305

Closed
oleq opened this issue Mar 8, 2018 · 3 comments · Fixed by ckeditor/ckeditor5-engine#1406
Closed

Re–entering the link selection mode takes an additional key press #4305

oleq opened this issue Mar 8, 2018 · 3 comments · Fixed by ckeditor/ckeditor5-engine#1406
Assignees
@szymonkups
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 16

Comments

@oleq
Copy link
Member

oleq commented Mar 8, 2018

  1. Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html
  2. Place the caret before the link.
  3. Press right arrow key until the link gets highlighted.
  4. Press the left arrow key to leave the link.
  5. Repeat 3.

Expected:

The same number of left/right key presses is used to enter and leave.

Actual:

When re-entering the link (4.), there's one additional ghost step before the link is highlighted.

kapture 2018-03-08 at 16 06 03

Related to https://github.com/ckeditor/ckeditor5-engine/issues/1301 (?)

cc @Reinmar @szymonkups
@Reinmar
Copy link
Member

Reinmar commented Mar 8, 2018

DUPs https://github.com/ckeditor/ckeditor5-engine/issues/1301#issuecomment-371093166 I think.

@oleq
Copy link
Member Author

oleq commented Mar 8, 2018

I'm not sure. @szymonkups?

@szymonkups
Copy link
Contributor

It looks like both issues are connected. Let's leave this open and we will check both scenarios during the work on #4277.

scofalik referenced this issue in ckeditor/ckeditor5-engine Apr 18, 2018
@scofalik
Merge pull request #1406 from ckeditor/t/1301
f0fd2d8 
Fix: The `bindTwoStepCaretToAttribute` behavioral helper should not fail in more complex cases. Closes #1301. Closes #1346. Closes ckeditor/ckeditor5#937.  Closes ckeditor/ckeditor5#922.  Closes ckeditor/ckeditor5#946.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 16 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 16
4 participants
@Reinmar @oleq @szymonkups @mlewand