Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling is lost after typing outside of the link #922

Closed
Mgsy opened this issue Mar 26, 2018 · 3 comments · Fixed by ckeditor/ckeditor5-engine#1406
Closed

Styling is lost after typing outside of the link #922

Mgsy opened this issue Mar 26, 2018 · 3 comments · Fixed by ckeditor/ckeditor5-engine#1406
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 16

Comments

@Mgsy
Copy link
Member

Mgsy commented Mar 26, 2018

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

Latest master.

📋 Steps to reproduce

  1. Open the article sample.
  2. Put the caret at the end of the link.
  3. Press Arrow right to exit the link.
  4. Activate the bold.
  5. Type two characters.

✅ Expected result

The styling is preserved.

❎ Actual result

The styling is lost on the second character.

📃 Other details that might be useful

GIF

bug_cke5

OS: All platforms
Browser: All browsers
@Mgsy Mgsy added the type:bug This issue reports a buggy (incorrect) behavior. label Mar 26, 2018
@Reinmar
Copy link
Member

Reinmar commented Mar 26, 2018

Apparently, the gravity isn't reset on selection attrs being changed. So, the selection gets the bold attr, but since the gravity is set to right, it loses it after a character is inserted.

@Reinmar Reinmar modified the milestones: iteration 15, backlog Mar 26, 2018
@Reinmar
Copy link
Member

Reinmar commented Apr 5, 2018

@oleq, please remember about this case when you'll be refactoring the 2SCM.

@oleq
Copy link
Member

oleq commented Apr 6, 2018

A cross-reference https://github.com/ckeditor/ckeditor5-engine/issues/1301.

@oleq oleq mentioned this issue Apr 16, 2018
Merged
scofalik added a commit to ckeditor/ckeditor5-engine that referenced this issue Apr 18, 2018
@scofalik
Merge pull request #1406 from ckeditor/t/1301
f0fd2d8 
Fix: The `bindTwoStepCaretToAttribute` behavioral helper should not fail in more complex cases. Closes #1301. Closes #1346. Closes ckeditor/ckeditor5#937.  Closes ckeditor/ckeditor5#922.  Closes ckeditor/ckeditor5#946.
@Reinmar Reinmar modified the milestones: backlog, iteration 16 Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 16
3 participants
@Reinmar @oleq @Mgsy