This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Fix: made startsWithFiller to use safe isText check instead of instanceof
#1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstanceof` Using `domNode instanceof Text` is not safe and may cause issues e.g. across iframes.
|
Hi, @dimaip :) Thanks for the PR! I have only one doubt - the iframe will persist in the DOM after your test. Could you detach the iframe after the test, so the testing environment will stay clean? |
|
@ma2ciek sure, wasn't aware it's not somehow destroyed between the tests. |
|
@ma2ciek ok, looks like the tests are green |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
startsWithFillershould correctly work with DOMTextnodes that are inside of an iframe.