This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Internal: Improved serialization of WrapOperation. #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scofalik
reviewed
Aug 17, 2018
src/model/operation/wrapoperation.js
Outdated
| @@ -31,7 +31,7 @@ export default class WrapOperation extends Operation { | |||
| * @param {Number} howMany Offset size of wrapped range. Wrapped range will start at `position.offset` and end at | |||
| * `position.offset + howMany`. | |||
| * @param {module:engine/model/element~Element|module:engine/model/position~Position} elementOrPosition Element to | |||
| * wrap with or position in graveyard before the element which should be used as a wrapper. | |||
| * wrap or position in graveyard before the element which should be used as a wrapper. | |||
There was a problem hiding this comment.
"Element to wrap" sounds like the element that will be wrapped. this.element is the wrapping element. So, okay, I understand that you think that the word "with" is incorrect here, but it cannot be like you wrote. Other suggestions:
- "Element to wrap in"
- "Wrapper element"
- "Wrapping element"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Improved serialization of WrapOperation. Closes ckeditor/ckeditor5#4400.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.